Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][Graph] Add debug print graph functionality #252

Merged
merged 1 commit into from
Jul 18, 2023
Merged

[SYCL][Graph] Add debug print graph functionality #252

merged 1 commit into from
Jul 18, 2023

Conversation

mfrancepillois
Copy link
Collaborator

Adds two debugging features:

  • debug print graph
  • similar graph structure checker

@mfrancepillois mfrancepillois added the Graph Implementation Related to DPC++ implementation and testing label Jul 7, 2023
EwanC
EwanC reviewed Jul 10, 2023
View reviewed changes
sycl/source/detail/graph_impl.hpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.cpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.cpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/ext/oneapi/experimental/graph.hpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.hpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.hpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.hpp Show resolved Hide resolved
sycl/include/sycl/detail/cg.hpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.hpp Outdated Show resolved Hide resolved
@mfrancepillois mfrancepillois force-pushed the maxime/graph_debug_functions_print_check_sim branch from f70043b to 2c70c83 Compare July 10, 2023 16:15
Bensuo
Bensuo reviewed Jul 10, 2023
View reviewed changes
Copy link
Collaborator

@Bensuo Bensuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a partial review, will take a better look tomorrow.

sycl/include/sycl/ext/oneapi/experimental/graph.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/ext/oneapi/experimental/graph.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/ext/oneapi/experimental/graph.hpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.cpp Outdated Show resolved Hide resolved
@mfrancepillois mfrancepillois force-pushed the maxime/graph_debug_functions_print_check_sim branch from 2c70c83 to c553a64 Compare July 11, 2023 09:16
Bensuo
Bensuo approved these changes Jul 11, 2023
View reviewed changes
sycl/include/sycl/ext/oneapi/experimental/graph.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/ext/oneapi/experimental/graph.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/ext/oneapi/experimental/graph.hpp Outdated Show resolved Hide resolved
sycl/include/sycl/ext/oneapi/experimental/graph.hpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.cpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.hpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.hpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.hpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.hpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.hpp Outdated Show resolved Hide resolved
@mfrancepillois mfrancepillois force-pushed the maxime/graph_debug_functions_print_check_sim branch 3 times, most recently from 77028db to 8ef444a Compare July 12, 2023 15:33
EwanC
EwanC reviewed Jul 13, 2023
View reviewed changes
sycl/source/detail/graph_impl.hpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.cpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.hpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.hpp Outdated Show resolved Hide resolved
sycl/source/detail/graph_impl.hpp Outdated Show resolved Hide resolved
@mfrancepillois mfrancepillois force-pushed the maxime/graph_debug_functions_print_check_sim branch from 8ef444a to d81ea9f Compare July 14, 2023 09:23
@mfrancepillois
[SYCL][Graph] Add debug print graph functionality
009de20 
Adds two debugging features:
 - debug print graph
 - similar graph structure checker
@mfrancepillois mfrancepillois force-pushed the maxime/graph_debug_functions_print_check_sim branch from d81ea9f to 009de20 Compare July 14, 2023 09:28
EwanC
EwanC approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing all my comments

@mfrancepillois mfrancepillois merged commit 586c9ad into sycl-graph-develop Jul 18, 2023
@mfrancepillois mfrancepillois deleted the maxime/graph_debug_functions_print_check_sim branch July 18, 2023 07:51
@Bensuo Bensuo mentioned this pull request Jul 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EwanC EwanC EwanC approved these changes

@Bensuo Bensuo Bensuo approved these changes

@reble reble Awaiting requested review from reble

@julianmi julianmi Awaiting requested review from julianmi

Assignees
No one assigned
Labels
Graph Implementation Related to DPC++ implementation and testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mfrancepillois @EwanC @Bensuo