[SYCL][Graph] Refactor node storage inside graphs #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Bensuo
commented
Oct 20, 2023
•
Bensuo
commented
- Store graph nodes inside a vector instead for more optimal searches
- Replace several depth first search operations with iterations over node storage
- Node successors are now weak_ptrs
- Remove node_impl::operator== and move functionality to isSimilar()
- Unit tests updated to reflect changes
Bensuo
added
the
Graph Implementation
EwanC
reviewed
Oct 23, 2023
There was a problem hiding this comment.
Overall the change LGTM, do have minor comments on:
- braces on if statements
- using
constin some functions.
My only other comment is that the PR description says: "Store graph nodes inside a vector instead of in a linked list". But we're not removing any member variables from the graph, so the linked list structure is still there to use (albeit via weak_ptrs). So think this bulletpoint could be rephrased to something like "Store graph nodes inside a vector for more optimal search" (or whatever)
- Store graph nodes inside a vector for more optimal search - Replace several depth first search operations with iterations over node storage - Node successors are now weak_ptrs - Remove node_impl::operator== and move functionality to isSimilar() - Unit tests updated to reflect changes
- Style fixes - Make MRoots weak_ptrs instead of shared
Bensuo
force-pushed
the
ben/node-storage-refactor
branch
from
2da28fb
to
c9cfc73
Compare
EwanC
approved these changes
Oct 23, 2023
|
Closing this now, further review can be carried out on the upstream PR here: intel#11596 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.