Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][Graph] Add Graphs printing API to spec #337

Closed
wants to merge 1 commit into from
Closed

[SYCL][Graph] Add Graphs printing API to spec #337

wants to merge 1 commit into from

Conversation

mfrancepillois
Copy link
Collaborator

Updates the Spec with the proposed API for debug print graph

@EwanC EwanC added the Graph Specification Extension Specification related label Oct 30, 2023
@mfrancepillois mfrancepillois marked this pull request as ready for review October 31, 2023 14:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 31, 2023 •
edited
Loading

✅ With the latest revision this PR passed the C/C++ code formatter.

EwanC
EwanC reviewed Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good, the last thing I think this needs is some testing. Don't have a clear idea how this would look. We could use unittests because this output doesn't need a backend, but the FileCheck tool in lit would also be handy for pattern matching the expected dot file output.

@mfrancepillois
Copy link
Collaborator Author

Tests checking the printed graph with and without verbosity have been added.

EwanC
EwanC approved these changes Nov 2, 2023
View reviewed changes
Copy link
Collaborator

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙂

@mfrancepillois
[SYCL][Graph] Add Graphs printing API
1bff3f7 
Updates Sycl-Graph API with a graph print function outputing a dot graph that represents the created modifiable graph.
Updates the Spec with the proposed API for debug print graph.
Adds e2e tests that check the behavior of this function.
@mfrancepillois
Copy link
Collaborator Author

Upstream PR intel#11796

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianmi julianmi julianmi left review comments

@Bensuo Bensuo Bensuo approved these changes

@EwanC EwanC EwanC approved these changes

@reble reble Awaiting requested review from reble

Assignees
No one assigned
Labels
Graph Specification Extension Specification related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mfrancepillois @EwanC @Bensuo @julianmi