Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SYCL][Graph] Avoid unnecessary inter-partition dependencies #354

Closed
wants to merge 1 commit into from

Conversation

mfrancepillois
Copy link
Collaborator

Improves management of inter-partition dependencies, so that only required dependencies are added.
As removing these dependencies can results in multiple executions paths, we have added a map to track all events returned from submitted partitions.
All these events are linked to the main event returned to user.
Adds tests.

@mfrancepillois mfrancepillois added the Graph Implementation Related to DPC++ implementation and testing label Jan 31, 2024
Copy link
Collaborator

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks reasonable, main comment I have is that it would be easier to review and maintain if there was a diagram somewhere of before and after this change.

sycl/source/detail/graph_impl.hpp Show resolved Hide resolved
Copy link
Collaborator

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation is a great addition 👍

sycl/doc/design/CommandGraph.md Outdated Show resolved Hide resolved
sycl/doc/design/CommandGraph.md Outdated Show resolved Hide resolved
Improves management of inter-partition dependencies, so that only required dependencies are added.
As removing these dependencies can results in multiple executions paths, we have added a map to track all events returned from submitted partitions.
All these events are linked to the main event returned to user.
Adds tests.
@mfrancepillois
Copy link
Collaborator Author

Upstream PR: intel#12680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Graph Implementation Related to DPC++ implementation and testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants