Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SYCL][Graph] Add External Events APIs #355

Closed
wants to merge 10 commits into from
Closed

[SYCL][Graph] Add External Events APIs #355

wants to merge 10 commits into from

Commits on Apr 22, 2024

  1. [SYCL][Graph] Add External Events APIs 

    Updates specification with new APIs for handling external events in Record&Replay and Explicit mode.
Adds 3 functions to `graph`:
- add_barrier()
- make_external_event()
- update_external_event()
Adds 1 function to `queue`:
- ext_oneapi_external_event()
Adds examples to show how to use these functions.

update spec

Fix issue in the second code example.
    @mfrancepillois @Bensuo
    mfrancepillois authored and Bensuo committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    80a4000 View commit details
    Browse the repository at this point in the history

  2. [SYCL][Graph] External event changes 

    - Remove updating and profiling capabilities
- Simplify and align interfaces for getting external events
- Restrict external event use within the graph (prevents needing graph-limited event from queue shortcut)
    @Bensuo
    Bensuo committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    00fae5b View commit details
    Browse the repository at this point in the history

  3. Fix typos

    @Bensuo
    Bensuo committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    e0dc8d1 View commit details
    Browse the repository at this point in the history

  4. Restore event limitations 

    - Restore forbidding outside graph deps that are not external events
    @Bensuo
    Bensuo committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    69b1d04 View commit details
    Browse the repository at this point in the history

  5. Replace is_graph_limited with event info query

    @Bensuo
    Bensuo committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    898e58d View commit details
    Browse the repository at this point in the history

  6. Addressing review comments 

    - Rename add_barrier to add_wait_external_event
- Clarify wording about edges and ext events
- Minor formatting and wording changes
    @Bensuo
    Bensuo committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    3714f8f View commit details
    Browse the repository at this point in the history

  7. Remove duplicate wording

    @Bensuo
    Bensuo committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    9c27142 View commit details
    Browse the repository at this point in the history

  8. Minor wording update

    @Bensuo
    Bensuo committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    df48b8a View commit details
    Browse the repository at this point in the history

  9. Restore using events from outside graph 

    - Useful for warmups etc.
    @Bensuo
    Bensuo committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    75f8c14 View commit details
    Browse the repository at this point in the history

  10. Add some more external event examples

    @Bensuo
    Bensuo committed Apr 22, 2024
    Configuration menu
    Copy the full SHA
    35788b5 View commit details
    Browse the repository at this point in the history