[SYCL][Graph] Add test for using spirv kernels in graphs #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabiomestre
commented
Apr 17, 2024
Bensuo
approved these changes
Apr 18, 2024
Comment on lines
1
to
2
| // RUN: %{build} -o %t.out | ||
| // RUN: %if level_zero %{%{run} %t.out %S/../Inputs/Kernels/kernels.spv %} |
There was a problem hiding this comment.
Does it make more sense to add REQUIRES: level_zero here instead of only guarding the execution line itself? There's not much point in building the test for unsupported backends, and then we can just add/change/remove the REQUIRES if/when we can enable this test for more backends.
We could also potentially add the standard extra RUN lines for L0 leaks/immediate command list testing here.
This comment also applies to the other new test.
EwanC
approved these changes
Apr 22, 2024
|
Upstream PR: intel#13532 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.