[SYCL][Graph] Update begin_recording and end_recording #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removes bool return value from being_recording() and end_recording() - Adds missing property_list parameter to the implementation of begin_recording()
EwanC
reviewed
Apr 22, 2024
|
Upstream PR: intel#13480 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bool return value was removed because there are no good usecases for it. The sycl way to handle errors is to return exceptions. The original reasoning to have a bool return value was that the application would likely ignore the exceptions in this entrypoint. There is no reason to believe that they will check the bool return either if it serves no practical purpose.