This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 724
Add filter for opensearch default packages #1130
Merged
bjoernhaeuser
merged 15 commits into
rebuy-de:main
from
oreillymedia:Add-Opensearch-Packages-VPCEndpoint-Support
Oct 23, 2023
Merged
Add filter for opensearch default packages #1130
bjoernhaeuser
merged 15 commits into
rebuy-de:main
from
oreillymedia:Add-Opensearch-Packages-VPCEndpoint-Support
Oct 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding support for opensearch packages.
Confirmed working cleanup of os packages.
Removing unused var from packages.
Correctly retrieving VPC endpoint ids.
Setting property values.
Adding id to properties.
Removing unneeded describe call.
Removed extra function for getting id's, incorporated into list function.
der-eismann
approved these changes
Oct 23, 2023
Hey @swhite-oreilly, thanks for the quick fix! Highly appreciated 🙂 |
svenwltr
approved these changes
Oct 23, 2023
swhite-oreilly
deleted the
Add-Opensearch-Packages-VPCEndpoint-Support
branch
October 25, 2023 22:50
ppmathis
added a commit
to ppmathis/aws-auto-nuke
that referenced
this pull request
Oct 28, 2023
* upstream/main: Bump the golang group with 1 update (rebuy-de#1133) Add filter for opensearch default packages (rebuy-de#1130) Bump the golang group with 1 update (rebuy-de#1122) Bump the golang group with 2 updates (rebuy-de#1120)
fridim
added a commit
to rhpds/sandbox
that referenced
this pull request
Nov 16, 2023
see rebuy-de/aws-nuke#1123 Remove for next version when this fix is included rebuy-de/aws-nuke#1130
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes adds a filter for default Opensearch packages that were recently added by AWS. (We confirmed with AWS support that AWS created packages are the only ones that will have an ID prefix of G).
Testing
The following script adds a custom opensearch domain with packages. After running this script, you can confirm the default packages are now skipped and only user created packages will get removed.