Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 2296521: [release-4.16] api: update ocs-operator pkg version #424

Conversation

Nikhil-Ladha
Copy link
Member

Update ocs-operator pkg version to include new api changes
Ref BZ: https://bugzilla.redhat.com/show_bug.cgi?id=2276694

update ocs-operator pkg version to
include new api changes

Signed-off-by: Nikhil-Ladha <nikhilladha1999@gmail.com>
Copy link
Contributor

openshift-ci bot commented Jun 6, 2024

@Nikhil-Ladha: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.16] api: update ocs-operator pkg version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 6, 2024
Copy link
Contributor

openshift-ci bot commented Jun 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, Nikhil-Ladha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 6, 2024
@Nikhil-Ladha
Copy link
Member Author

@iamniting I guess we can merge this (and other backports) PR without a bz, right?

@iamniting
Copy link
Member

@iamniting I guess we can merge this (and other backports) PR without a bz, right?

no we need BZ

@Nikhil-Ladha Nikhil-Ladha changed the title [release-4.16] api: update ocs-operator pkg version Bug 2296521: [release-4.16] api: update ocs-operator pkg version Sep 25, 2024
Copy link
Contributor

openshift-ci bot commented Sep 25, 2024

@Nikhil-Ladha: This pull request references Bugzilla bug 2296521, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (ODF 4.16.3) matches configured target release for branch (ODF 4.16.3)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

No GitHub users were found matching the public email listed for the QA contact in Bugzilla (ebenahar@redhat.com), skipping review request.

In response to this:

Bug 2296521: [release-4.16] api: update ocs-operator pkg version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@Nikhil-Ladha
Copy link
Member Author

/retest

@Nikhil-Ladha
Copy link
Member Author

Nikhil-Ladha commented Sep 25, 2024

@iamniting we are using gingko@latest in make-tools i.e, causing to download the latest gingko version which requires golang 1.22. I think we should pin to a version similar to one we use in go.mod. WDYT?
Ref: https://github.com/red-hat-storage/odf-operator/blob/release-4.16/hack/make-tools.mk#L17

@iamniting
Copy link
Member

@iamniting we are using gingko@latest in make-tools i.e, causing to download the latest gingko version which requires golang 1.22. I think we should pin to a version similar to one we use in go.mod. WDYT? Ref: https://github.com/red-hat-storage/odf-operator/blob/release-4.16/hack/make-tools.mk#L17

Yes, we should do that, Can you pls create the required PRs in all branches I will merge them without the bugs.

@Nikhil-Ladha
Copy link
Member Author

Here's the PR: #484

@iamniting
Copy link
Member

/test odf-operator-e2e-aws

@openshift-merge-bot openshift-merge-bot bot merged commit eddacef into red-hat-storage:release-4.16 Sep 25, 2024
18 checks passed
Copy link
Contributor

openshift-ci bot commented Sep 25, 2024

@Nikhil-Ladha: All pull requests linked via external trackers have merged:

Bugzilla bug 2296521 has been moved to the MODIFIED state.

In response to this:

Bug 2296521: [release-4.16] api: update ocs-operator pkg version

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium bugzilla/valid-bug lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants