bundle: add new OLM dependencie ceph csi operator #439
Conversation
openshift-ci
bot
added
the
approved
hack/make-bundle-vars.mk
Outdated
| CEPHCSI_BUNDLE_NAME ?= cephcsi-operator | ||
| CEPHCSI_BUNDLE_IMG_NAME ?= $(CEPHCSI_BUNDLE_NAME)-bundle | ||
| CEPHCSI_BUNDLE_VERSION ?= v4.17.0 | ||
| CEPHCSI_BUNDLE_IMG_TAG ?= main-5074691 | ||
| CEPHCSI_BUNDLE_IMG_LOCATION ?= quay.io/ocs-dev | ||
| CEPHCSI_BUNDLE_IMG ?= $(CEPHCSI_BUNDLE_IMG_LOCATION)/$(CEPHCSI_BUNDLE_IMG_NAME):$(CEPHCSI_BUNDLE_IMG_TAG) |
There was a problem hiding this comment.
use CEPHCSI_OPERATOR instead of CEPHCSI
There was a problem hiding this comment.
Madhu it is done like this for all other operators. I would like to keep the same for this too.
| CEPHCSI_SUBSCRIPTION_NAME ?= $(CEPHCSI_BUNDLE_NAME) | ||
| CEPHCSI_SUBSCRIPTION_PACKAGE ?= $(CEPHCSI_BUNDLE_NAME) | ||
| CEPHCSI_SUBSCRIPTION_CHANNEL ?= $(DEFAULT_CHANNEL) | ||
| CEPHCSI_SUBSCRIPTION_STARTINGCSV ?= $(CEPHCSI_BUNDLE_NAME).$(CEPHCSI_BUNDLE_VERSION) | ||
| CEPHCSI_SUBSCRIPTION_CATALOGSOURCE ?= $(OPERATOR_CATALOGSOURCE) | ||
| CEPHCSI_SUBSCRIPTION_CATALOGSOURCE_NAMESPACE ?= $(OPERATOR_CATALOGSOURCE_NAMESPACE) |
There was a problem hiding this comment.
same here as well, can we use CEPHCSI_OPERATOR
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, Nikhil-Ladha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit 141d915
into
red-hat-storage:main
|
/cherry-pick release-4.17 |
|
@iamniting: new pull request created: #463 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Nitin Goyal nigoyal@redhat.com