Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.15] create a mechanism to deploy odf using operator-sdk #440

Merged

Conversation

iamniting
Copy link
Member

@iamniting iamniting commented Jul 12, 2024

This is an manual cherry-pick of #394 #412

Copy link
Contributor

openshift-ci bot commented Jul 12, 2024

@iamniting: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.15] create a mechanism to deploy odf using operator-sdk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 12, 2024
@iamniting
Copy link
Member Author

/test images

Copy link
Contributor

@malayparida2000 malayparida2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2024
hack/install-odf.sh Outdated Show resolved Hide resolved
.github/workflows/docker-build.yaml Outdated Show resolved Hide resolved
@malayparida2000
Copy link
Contributor

/lgtm cancel

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2024
Copy link
Member

@Nikhil-Ladha Nikhil-Ladha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 12, 2024
Copy link
Member

@Nikhil-Ladha Nikhil-Ladha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

openshift-ci bot commented Jul 12, 2024

@iamniting: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.15] create a mechanism to deploy odf using operator-sdk

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 12, 2024
@iamniting
Copy link
Member Author

/retest-required

@iamniting
Copy link
Member Author

/retest images

Copy link
Contributor

openshift-ci bot commented Jul 17, 2024

@iamniting: The /retest command does not accept any targets.
The following commands are available to trigger required jobs:

  • /test ci-bundle-odf-operator-bundle
  • /test images
  • /test odf-operator-e2e-aws

Use /test all to run all jobs.

In response to this:

/retest images

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@iamniting
Copy link
Member Author

/test images

@iamniting
Copy link
Member Author

/test odf-operator-e2e-aws

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2024
A separate catalog image will be used in the openshift CI

Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2024
Copy link
Contributor

openshift-ci bot commented Jul 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamniting, malayparida2000, Nikhil-Ladha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit af18f28 into red-hat-storage:release-4.15 Jul 17, 2024
17 checks passed
@iamniting
Copy link
Member Author

/cherry-pick release-4.14
/cherry-pick release-4.13
/cherry-pick release-4.12

@openshift-cherrypick-robot

@iamniting: new pull request created: #447

In response to this:

/cherry-pick release-4.14
/cherry-pick release-4.13
/cherry-pick release-4.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@iamniting
Copy link
Member Author

/cherry-pick release-4.13

@openshift-cherrypick-robot

@iamniting: #440 failed to apply on top of branch "release-4.13":

Applying: makefile: create a separate catalog image for deps
Using index info to reconstruct a base tree...
M	Makefile
M	hack/make-bundle-vars.mk
Falling back to patching base and 3-way merge...
Auto-merging hack/make-bundle-vars.mk
Auto-merging Makefile
Applying: action: update action to verify catalog changes
Using index info to reconstruct a base tree...
M	.github/workflows/docker-build.yaml
Falling back to patching base and 3-way merge...
Auto-merging .github/workflows/docker-build.yaml
CONFLICT (content): Merge conflict in .github/workflows/docker-build.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0002 action: update action to verify catalog changes
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-4.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants