update ibm odf operator to 1.6.0 #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
the
approved
iamniting
force-pushed
the
ibm
branch
6 times, most recently
from
4a51560
to
8888630
Compare
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
IBM has published multiple 1.6.0 releases, and the goproxy server is still holding outdated 1.6.0 release information. To address this issue, we will begin using the direct proxy instead of the goproxy server. Signed-off-by: Nitin Goyal <nigoyal@redhat.com>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, Nikhil-Ladha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -5,7 +5,7 @@ ENVTEST_ASSETS_DIR := $(PROJECT_DIR)/testbin | |||
| GOBIN ?= $(BIN_DIR) | |||
| GOOS ?= $(shell go env GOOS) | |||
| GOARCH ?= $(shell go env GOARCH) | |||
| GOPROXY ?= https://proxy.golang.org/ | |||
| GOPROXY ?= direct,https://proxy.golang.org | |||
There was a problem hiding this comment.
When we use the direct proxy what exactly it does? Does it slow down the go mod tidy process?
There was a problem hiding this comment.
yes it does slow down a bit and directly fetches the APIS from the src instead of the goproxy server.
openshift-merge-bot
bot
merged commit 8d4683c
into
red-hat-storage:main
17 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nitin Goyal nigoyal@redhat.com