Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Bump intellij-common-ui-test-library version to 0.4.2 #1392

Merged
merged 3 commits into from
Oct 22, 2024
Merged

fix: Bump intellij-common-ui-test-library version to 0.4.2 #1392

merged 3 commits into from
Oct 22, 2024

Conversation

olkornii
Copy link
Contributor

@olkornii olkornii commented Oct 2, 2024 •
edited
Loading

Older version of intellij-library does not support "platformType" and "platformVersion" properties.
fixes: #1348

@olkornii olkornii added the tests Testing related issue label Oct 2, 2024
@olkornii olkornii self-assigned this Oct 2, 2024
@olkornii olkornii marked this pull request as draft October 2, 2024 12:08
@olkornii
Bump intellij-common-ui-test-library version to 0.4.2
56741c8 
Signed-off-by: Oleksii Korniienko <olkornii@redhat.com>
@olkornii
Added "setProjectLocation" for new Quarkus project page
37ccade 
Signed-off-by: Oleksii Korniienko <olkornii@redhat.com>
@olkornii olkornii force-pushed the issue-1348 branch 2 times, most recently from 6948ff9 to cdd57e4 Compare October 16, 2024 12:10
@olkornii
Copy link
Contributor Author

olkornii commented Oct 17, 2024 •
edited
Loading

@angelozerr @fbricon
Hi, looks like ITs are green.
I just wanna ask you to check Java CI with Gradle GHAs and review the PR :)

@angelozerr
Copy link
Contributor

I restarted the Java CI build (it is a very annoying problem, because sometimes it fails) and CI buld seems working pretty well!

Good job @olkornii !

@olkornii
Copy link
Contributor Author

Thank you @angelozerr :)
I'll fix this typo tomorrow and ping you. I think we will merge it tomorrow :)

@olkornii
Changed quarkus project location due to updates in test-library 0.4.2
05b3308 
Signed-off-by: Oleksii Korniienko <olkornii@redhat.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 22, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@olkornii olkornii marked this pull request as ready for review October 22, 2024 09:58
@olkornii
Copy link
Contributor Author

@angelozerr should we just rerun failed CI test?

@angelozerr
Copy link
Contributor

All tests are working. Thanks @olkornii !

@angelozerr angelozerr merged commit fec9bb1 into redhat-developer:main Oct 22, 2024
10 checks passed
@angelozerr angelozerr added this to the 2.1.0 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbricon fbricon Awaiting requested review from fbricon

@angelozerr angelozerr Awaiting requested review from angelozerr

Assignees

@olkornii olkornii

Labels
tests Testing related issue
Projects
IDE Cloudaptors
Status: ✅ Done
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.

Bump intellij-common-ui-test-library version
2 participants
@olkornii @angelozerr