Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust to new hover behviour for enum #1030

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

datho7561
Copy link
Contributor

Signed-off-by: David Thompson davthomp@redhat.com

What does this PR do?

Fix the integration test for hover

What issues does this PR fix or reference?

The integration test for hover

Is it tested? How?

It's a fix to a test

@datho7561
Copy link
Contributor Author

Tests pass locally for me. Is vscide-yaml using the right server version?

@datho7561
Copy link
Contributor Author

datho7561 commented Jun 6, 2024

If I try to set the yaml-language-server version to 1.15, then yarn build fails. Did the release go okay?

My bad I unlinked yaml-language-sever, which I didn't realize would remove it from the package.json entirely

Signed-off-by: David Thompson <davthomp@redhat.com>
@rgrunber rgrunber merged commit 98d0812 into redhat-developer:main Jun 6, 2024
3 checks passed
@datho7561 datho7561 deleted the fix-hover-test-content branch June 6, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants