Changing the module context rule as it doesn't highlight anything in VS Code #658
Conversation
rohennes
added
the
OpenShiftAsciiDoc
|
⚡️ Deploying PR Preview... |
|
Click here to review and test in web IDE: |
| //add a newline, it might be missing | ||
| scope += "\n" | ||
|
|
||
| context_regex := ":_content-type:(\\s)?(CONCEPT|SNIPPET|ASSEMBLY|PROCEDURE|REFERENCE)" |
There was a problem hiding this comment.
Pretty sure the variable needs precisely one space after the variable name or AsciiDoctor complains
There was a problem hiding this comment.
| context_regex := ":_content-type:(\\s)?(CONCEPT|SNIPPET|ASSEMBLY|PROCEDURE|REFERENCE)" | |
| context_regex := "^:_(mod-docs-)?content-type:\\s+(CONCEPT|SNIPPET|ASSEMBLY|PROCEDURE|REFERENCE)" |
The modular-docs project recently changed the names of the attributes identifying the module type.
There was a problem hiding this comment.
Thanks @jhradilek - I don't think OpenShift have yet implemented this change, but when it does, I will need to update this rule. (This rule set is OpenShift specific)
There was a problem hiding this comment.
Pretty sure the variable needs precisely one space after the variable name or AsciiDoctor complains
Updated. Does this work @aireilly ?
There was a problem hiding this comment.
IMO - if there is a failing on the VS Code plugin side, I would prefer to see that corrected rather than working around it with this update.
There was a problem hiding this comment.
Created ChrisChinchilla/vale-vscode#14
rohennes
force-pushed
the
module-context-using-tengo
branch
2 times, most recently
from
191fc5a to
bea7e17
Compare
rohennes
force-pushed
the
module-context-using-tengo
branch
3 times, most recently
from
13c3461 to
c74cbde
Compare
…VS Code. Using tengo you can highlight first line.
rohennes
force-pushed
the
module-context-using-tengo
branch
from
c74cbde to
849a0b3
Compare
The rule to check for the presence of the :_content-type: in a module works but it doesn't show any line highlighting in VS Code. It only show the error on the cmd line.
This PR changes the rule to a tengo script, which highlights the first line of the file if it doesn't find the variable.