Remove caching for some find images APIs #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caching should not be enabled for some find images APIs, because the
result can change at any time, if we have caching for such APIs, images
just be released may not be returned by these APIs which can cause
wrong result of images to be rebuilt.
These APIs are from `pyxis_gql` module:
1. find_images_by_installed_rpms
2. find_images_by_names
3. find_images_by_name_version
4. find_images_by_repository
Caching for other find images APIs is fine:
1. find_images_by_nvr
2. find_images_by_nvrs
FernandesMF
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caching should not be enabled for some find images APIs, because the result can change at any time, if we have caching for such APIs, images just be released may not be returned by these APIs which can cause wrong result of images to be rebuilt.
These APIs are from
pyxis_gqlmodule:Caching for other find images APIs is fine: