Refactor the Container class #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qixiang
force-pushed
the
container-class-refactor
branch
from
36f7131 to
3d34da3
Compare
Changes to the Container class: 1. Change Container class to normal class The class originally implemented using dataclass didn't have many of the advantages of dataclass, but rather made creating instances more difficult to understand. The reason is a container can have multi-arch images, most attributions doesn't have one-to-one mapping with a single image data. 2. Use class method `create_from_images` to create Container instances It was implemented with instantiating it first then load per-arch data with `load` which is confusing. 3. Remove `resolve_published` Just check if a container is published by checking that in all deliver repositories. JIRA: CWFHEALTH-2313
qixiang
force-pushed
the
container-class-refactor
branch
from
3d34da3 to
daf44e7
Compare
FernandesMF
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to the Container class:
The class originally implemented using dataclass didn't have many of the advantages of dataclass, but rather made creating instances more difficult to understand. The reason is a container can have multi-arch images, most attributions doesn't have one-to-one mapping with a single image data.
create_from_imagesto create Container instancesIt was implemented with instantiating it first then load per-arch data with
loadwhich is confusing.resolve_publishedJust check if a container is published by checking that in all deliver repositories.
JIRA: CWFHEALTH-2313