Ignore images with missing brew nvr data #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qixiang
reviewed
Oct 28, 2024
gnaponie
approved these changes
Oct 28, 2024
Images built and released by Konflux lack Brew metadata. Freshmaker will encounter problems, because it currently expects this data. This commit makes Freshmaker ignore those images. This is done in `images.PyxisAPI.find_images_with_included_rpms`, right after querying pyxis, by checking the brew nvr field.
FernandesMF
force-pushed
the
ignore_konflux_child_images
branch
2 times, most recently
from
bdc6300 to
901ae84
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Images built and released by Konflux lack Brew metadata. Freshmaker will encounter problems, because it currently expects this data.
This commit makes Freshmaker ignore those images. This is done in
images.PyxisAPI.find_images_with_included_rpms, right after querying pyxis, by checking the brew nvr field.