Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for creating a Custom Notebook Image #8

Merged
merged 8 commits into from
Sep 18, 2024

Conversation

theckang
Copy link
Contributor

@theckang theckang commented Aug 2, 2024

Created a section for creating custom notebook images and uploading them to RHOAI for new workbenches
Added example instructions for how-to on a Minimal Python notebook base image

@theckang theckang self-assigned this Aug 2, 2024
@codekow codekow self-requested a review August 2, 2024 16:21
@codekow
Copy link
Member

codekow commented Aug 2, 2024

@theckang Will you update this to use a build config and avoid using podman?

@codekow
Copy link
Member

codekow commented Aug 2, 2024

Copy link
Member

@codekow codekow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theckang See comments

@theckang
Copy link
Contributor Author

theckang commented Aug 5, 2024

@theckang Will you update this to use a build config and avoid using podman?

great idea, give me a few cycles to update

@theckang theckang requested a review from codekow August 13, 2024 02:06
@theckang
Copy link
Contributor Author

@codekow PR updated, podman removed

@codekow
Copy link
Member

codekow commented Aug 13, 2024

@theckang

I like the changes

What do you think about the following use cases:

  • Embeding the Containerfile in the build config (avoid any local tooling, modify only in the OCP console)?
    • In addition or in place of the local oc new-build?
  • Showing a (forked) external repo containing artifacts (this seems like it might be too much to me)

@theckang
Copy link
Contributor Author

@theckang

I like the changes

What do you think about the following use cases:

  • Embeding the Containerfile in the build config (avoid any local tooling, modify only in the OCP console)?

    • In addition or in place of the local oc new-build?
  • Showing a (forked) external repo containing artifacts (this seems like it might be too much to me)

Ideally - the user would fork the official notebook repo: https://github.com/red-hat-data-services/notebooks/tree/main/jupyter/minimal

And push Pipfile / Containerfile changes up and then launch a build off their fork.

This would require adding a bunch of Git commands and working with GitHub outside the terminal.

We could have a repo containing all the artifacts in advance, but I personally don't think the user would learn anything. I wanted to force the Containerfile creation and the Pipfile modifications to show how to make changes.

We could embed the Containerfile but there is still the Pipfile (and the associated pipenv lock) that is part of the build. I think if we wanted to bundle that as part of the build, the BYO-fork-repo is the right approach.

@codekow
Copy link
Member

codekow commented Aug 15, 2024

@theckang LGTM

@codekow
Copy link
Member

codekow commented Sep 5, 2024

@theckang You good with merging this?

@theckang
Copy link
Contributor Author

theckang commented Sep 5, 2024

got ask @dmarcus-wire as he wanted to see file restructuring - ready to merge?

@theckang theckang merged commit a2c72d9 into redhat-na-ssa:sa-bootcamp Sep 18, 2024
@theckang theckang deleted the kang-custom-image branch September 18, 2024 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants