-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add instructions for creating a Custom Notebook Image #8
Add instructions for creating a Custom Notebook Image #8
Conversation
@theckang Will you update this to use a build config and avoid using |
@theckang Here are some old examples you can un-suck. 😄 https://github.com/codekow/s2i-patch/blob/main/openshift/build-s2i-ms-odbc-17.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theckang See comments
great idea, give me a few cycles to update |
@codekow PR updated, podman removed |
I like the changes What do you think about the following use cases:
|
Ideally - the user would fork the official notebook repo: https://github.com/red-hat-data-services/notebooks/tree/main/jupyter/minimal And push Pipfile / Containerfile changes up and then launch a build off their fork. This would require adding a bunch of Git commands and working with GitHub outside the terminal. We could have a repo containing all the artifacts in advance, but I personally don't think the user would learn anything. I wanted to force the Containerfile creation and the Pipfile modifications to show how to make changes. We could embed the Containerfile but there is still the Pipfile (and the associated pipenv lock) that is part of the build. I think if we wanted to bundle that as part of the build, the BYO-fork-repo is the right approach. |
@theckang LGTM |
0eab152
to
6b72d4b
Compare
@theckang You good with merging this? |
got ask @dmarcus-wire as he wanted to see file restructuring - ready to merge? |
Created a section for creating custom notebook images and uploading them to RHOAI for new workbenches
Added example instructions for how-to on a
Minimal Python
notebook base image