Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh connection for pipeline when getting JedisMovedDataException #3699

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

stillerrr
Copy link
Contributor

pipelinedResponses should be clear in MultiNodePipelineBase.java and avoid this pipeline object reporting ENP when executing close() and reuse like #3697

MultiNodePipelineBase can be reused when calling close(), there is no switch to avoid this way to use MultiNodePipelineBase

stillerrr and others added 3 commits January 26, 2024 20:55
should get connection first and then create new pipeline queue, otherwise it would cause NPE when timeout for getting connection and call sync() method
pipelinedResponses  should be clear in MultiNodePipelineBase.java and avoid this pipeline object reporting ENP when executing close() and  reuse
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (64b5aac) 75.64% compared to head (09a1865) 75.65%.

❗ Current head 09a1865 differs from pull request most recent head 4404bbd. Consider uploading reports for the commit 4404bbd to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##             master    #3699   +/-   ##
=========================================
  Coverage     75.64%   75.65%           
- Complexity     4914     4915    +1     
=========================================
  Files           297      297           
  Lines         14956    14957    +1     
  Branches       1124     1124           
=========================================
+ Hits          11314    11316    +2     
  Misses         3149     3149           
+ Partials        493      492    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@sazzad16 sazzad16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stillerrr What about inner Queues in pipelinedResponses?

@stillerrr
Copy link
Contributor Author

@stillerrr What about inner Queues in pipelinedResponses?

I think it would be okay, the queue would be empty after executing sync(), but pipelinedResponses also has the empty queue

once the pipeline object is reused, there is no connection in connnections map, but has queue in pipelinedResponses map

@stillerrr stillerrr changed the title pipelinedResponses should be clear refresh connection for pipeline when getting JedisMovedDataException Aug 3, 2024
@stillerrr
Copy link
Contributor Author

@sazzad16 add method to refresh connection for pipeline when getting JedisMovedDataException

@stillerrr
Copy link
Contributor Author

@sazzad16 PTAL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants