Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RDS-1741 - Implement some missing checks. #21

Merged
merged 22 commits into from
Jan 13, 2025
Merged

RDS-1741 - Implement some missing checks. #21

merged 22 commits into from
Jan 13, 2025

Conversation

bartossh
Copy link
Contributor

@bartossh bartossh commented Jan 8, 2025

IMPLEMENTED ALREADY:

  • check if all timestamps of the processed payload are equal and non-zero ( in Payload.get_min_validated_timestamp() )

  • check if the data-point value-size is not exceeding 32 bytes (trait sanitized - panics if value exceeded)

  • check the vulnerability for the ecdsa signature malleability issue

DONE:

  • check if the signer list doesn’t contain duplicates

  • check if the feed_id list doesn’t contain duplicates

  • check if the feed_id list is non-empty

  • check the vulnerability for the ecdsa signature malleability issue

@bartossh bartossh self-assigned this Jan 8, 2025
@bartossh bartossh marked this pull request as draft January 8, 2025 16:53
Copy link
Contributor

@kostekIV kostekIV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice code, love the tests and docs. Left some nitpicks

crates/redstone/Cargo.toml Show resolved Hide resolved
crates/redstone/src/helpers/mod.rs Outdated Show resolved Hide resolved
crates/redstone/src/helpers/slice.rs Outdated Show resolved Hide resolved
crates/redstone/src/helpers/slice.rs Outdated Show resolved Hide resolved
crates/redstone/src/helpers/slice.rs Outdated Show resolved Hide resolved
crates/redstone/src/types/feed_id.rs Outdated Show resolved Hide resolved
crates/redstone/src/types/signer_address.rs Outdated Show resolved Hide resolved
crates/redstone/src/core/config.rs Outdated Show resolved Hide resolved
crates/redstone/src/core/config.rs Outdated Show resolved Hide resolved
crates/redstone/src/helpers/slice.rs Outdated Show resolved Hide resolved
crates/redstone/src/core/config.rs Outdated Show resolved Hide resolved
crates/redstone/src/core/config.rs Outdated Show resolved Hide resolved
crates/redstone/src/core/config.rs Outdated Show resolved Hide resolved
crates/redstone/src/core/config.rs Outdated Show resolved Hide resolved
crates/redstone/src/core/config.rs Show resolved Hide resolved
crates/redstone/src/core/config.rs Outdated Show resolved Hide resolved
crates/redstone/src/helpers/slice.rs Outdated Show resolved Hide resolved
crates/redstone/src/helpers/slice.rs Outdated Show resolved Hide resolved
crates/redstone/src/network/error.rs Outdated Show resolved Hide resolved
crates/redstone/src/network/error.rs Outdated Show resolved Hide resolved
@bartossh bartossh requested a review from kostekIV January 11, 2025 13:58
@bartossh bartossh marked this pull request as ready for review January 11, 2025 13:58
@bartossh bartossh requested a review from kostekIV January 13, 2025 07:57
@Lukasz2891 Lukasz2891 enabled auto-merge (squash) January 13, 2025 09:21
@Lukasz2891 Lukasz2891 merged commit 24f5189 into main Jan 13, 2025
1 check passed
@Lukasz2891 Lukasz2891 deleted the RDS-1741 branch January 13, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants