Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restores the code block style functionality for coaching Notes #58

Merged
merged 1 commit into from
Dec 24, 2024
Merged

Restores the code block style functionality for coaching Notes #58

merged 1 commit into from
Dec 24, 2024

Conversation

jhodapp
Copy link
Member

@jhodapp jhodapp commented Dec 24, 2024 •
edited
Loading

Description

This PR fixes the code block style bug and addresses the deprecation warning about the Sass @import statement.

GitHub Issue: Fixes #57

Changes

  • Fixes the code block style bug and addresses the deprecation warning about the Sass @import statement

Screenshots / Videos Showing UI Changes (if applicable)

Screenshot 2024-12-23 at 21 07 30

Testing Strategy

  1. Go to a coaching session
  2. Add a code block
  3. Observe that syntax highlighting and a code block now appear as expected

Concerns

None

@jhodapp jhodapp added the bug fix Fixes a specific Issue label Dec 24, 2024
@jhodapp jhodapp added this to the 1.0-rc2 milestone Dec 24, 2024
@jhodapp jhodapp requested review from qafui and calebbourg December 24, 2024 03:09
@jhodapp jhodapp self-assigned this Dec 24, 2024
@jhodapp jhodapp linked an issue Dec 24, 2024 that may be closed by this pull request
[Bug]: code block styling isn't working #57
Closed
@jhodapp jhodapp changed the title Fixes the code block style bug Restores the code block style functionality Dec 24, 2024
@jhodapp jhodapp changed the title Restores the code block style functionality Restores the code block style functionality for coaching Notes Dec 24, 2024
@jhodapp jhodapp merged commit 5737e20 into main Dec 24, 2024
1 check passed
@jhodapp jhodapp deleted the 57-bug-code-block-styling-isnt-working branch December 24, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qafui qafui Awaiting requested review from qafui

@calebbourg calebbourg Awaiting requested review from calebbourg

Assignees

@jhodapp jhodapp

Labels
bug fix Fixes a specific Issue
Projects
Refactor Coaching Platform
Status: ✅ Done
Milestone
1.0-rc2
Development

Successfully merging this pull request may close these issues.

[Bug]: code block styling isn't working
1 participant
@jhodapp