LinkInBio template with LaunchDarkly integration #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masenf
reviewed
Oct 18, 2024
|
Can do! — one moment!
|
|
@masenf removed the .venv directory — branch updated. erinmikailstaples:erin-final-edits |
elviskahoro
reviewed
Oct 18, 2024
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "githubPullRequests.ignoredPullRequestBranches": [ | |||
| "main" | |||
There was a problem hiding this comment.
Could we ignore this file?
|
@erinmikailstaples I'm running the tests! Will message you when they're done! |
|
hey @elviskahoro anything i can do to help with these tests? looking at it looks like its failing b/c its not picking up the ldclient import — going to check the requirements file. |
remove comment so the launchdakrly-server-sdk is installed.
update version
elviskahoro
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a link in bio template with a LaunchDarkly integration.