fix: lost secondary keyshares

Fix an unchecked overriding behavior which may lose pre-created handshake keys.
refraction-networking · Sep 4, 2023 · a9a1cc0 · a9a1cc0
1 parent fc79497
commit a9a1cc0
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/u_conn.go b/u_conn.go
@@ -567,7 +567,9 @@ func (c *UConn) clientHandshake(ctx context.Context) (err error) {
 		hs13 := c.HandshakeState.toPrivate13()
 		hs13.serverHello = serverHello
 		hs13.hello = hello
-		hs13.keySharesParams = NewKeySharesParameters()
+		if hs13.keySharesParams == nil {
+			hs13.keySharesParams = NewKeySharesParameters()
+		}
 		if !sessionIsLocked {
 			hs13.earlySecret = earlySecret
 			hs13.binderKey = binderKey