retract v1.4.1 panic #220
Merged
retract v1.4.1 panic #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
v1.4.1 may not be the only version that needs to be retracted. The actual breaking change has been made in v1.4.0. |
gaukas
reviewed
Aug 11, 2023
Retract v1.4.0 which also has the same bug. Update go.mod to update the dependency while not breaking existing functionality. Refresh go.sum to remove old entries.
|
@gaukas Sorry, I'm late, but we can add list of versions from to like this: [v1.4.0, v1.4.2], all version between 1.4.0 to 1.4.2 will be retract. |
|
Cool, thanks for the info. I don't think v1.4.2 is problematic so let's keep it for now. |
|
@gaukas Just an example haha 🤣 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retract v1.4.1 to prevent somebody use this version and get error with
go get github.com/refraction-networking/utls@latestIssues: #218 , imroc/req#263