Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add GREASEEncryptedClientHelloExtension #266

Merged
merged 12 commits into from
Dec 14, 2023
Merged

feat: add GREASEEncryptedClientHelloExtension #266

merged 12 commits into from
Dec 14, 2023

Conversation

gaukas
Copy link
Contributor

@gaukas gaukas commented Dec 12, 2023 •
edited
Loading

  • Finalize EncryptedClientHelloExtension interface
  • Add GREASEEncryptedClientHelloExtension extension
    • Correctly calculate the length of EncodedClientHelloInner
    • Allow specifying the length of payload
    • Randomize cipher suite, config id, enc, and payload
  • Handle EncryptedExtension encrypted_client_hello

Reference

@gaukas gaukas linked an issue Dec 12, 2023 that may be closed by this pull request
feat: GREASE ECH Extension #264
Closed
@gaukas

This comment was marked as resolved.

Sign in to view
@VeNoMouS

This comment was marked as resolved.

Sign in to view
@gaukas

This comment was marked as resolved.

Sign in to view
@gaukas
new: GREASE ECH extension
35850bc
@gaukas
fix: GREASE ECH Read must succeed with io.EOF
cc33c8e
@gaukas
new: GREASE ECH multiple payload len
af57f8f
@gaukas
new: parse ECH in EncryptedExtensions
f5775b9
@gaukas
fix: ECHConfig Length always 0
d154e24
@gaukas
new: GREASE ECH parrots
e8896dc
@gaukas
new: (*Config).ECHConfigs
9b025f1 
Add (*Config).ECHConfigs for future full ECH extension.
@gaukas
new: add GREASE ECH example
90d857e 
Add an incomplete example of using GREASE ECH extension (Chrome 120 parrot).
@gaukas
fix: invalid httpGetOverConn call
4bbf49d 
fix a problem in old example where httpGetOverConn was called with uTlsConn.HandshakeState.ServerHello.AlpnProtocol, which will not be populated in case TLS 1.3 is used.
@gaukas gaukas marked this pull request as ready for review December 14, 2023 00:10
@gaukas gaukas requested a review from ewust December 14, 2023 00:10
@gaukas gaukas changed the title new: add GREASEEncryptedClientHelloExtension feat: add GREASEEncryptedClientHelloExtension Dec 14, 2023
@gaukas gaukas self-assigned this Dec 14, 2023
@gaukas gaukas added the enhancement Feature with low severity but good value label Dec 14, 2023
@gaukas gaukas merged commit b4de442 into master Dec 14, 2023
This was referenced Dec 14, 2023
Closed
Closed
Open
@gaukas gaukas deleted the grease-ech branch December 14, 2023 20:42
@gaukas gaukas removed the request for review from ewust December 16, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@gaukas gaukas

Labels
enhancement Feature with low severity but good value
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: GREASE ECH Extension
2 participants
@gaukas @VeNoMouS