-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: vite migration #1955
chore: vite migration #1955
Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ac121b2
to
ba35dab
Compare
0845e7b
to
b537a89
Compare
With a fresh regen-web install, I can't reproduce the storybook dev server issue locally as described in https://www.notion.so/regennetwork/Engineering-Architecture-2023-07-06-c686348bcb2941ee8c0961a34589f3d2 |
406b229
to
0a83d69
Compare
vitePluginRequire(), | ||
visualizer(), | ||
], | ||
define: isDev ? { global: {} } : { 'process.env': {} }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see vitejs/vite#1973
we were getting errors when trying to login because @keplr-wallet/stores uses process.env internally
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why would they not support process.env
? 🤦
@erikalogie could you test that everything is working as expected on https://deploy-preview-1955--regen-registry.netlify.app/? Thanks! |
Ok @blushi this is what I found so far but I'm going to keep testing: This is a bit weird but is this just a metadata issue? https://monosnap.com/file/SrdM9rP9Dp5X4hFo6y59dQtc0Hn376 The impact cards width is not correct on project pages, should be as wide as the column and the OTC card below: https://monosnap.com/file/t5ZAGdCzMxq1LAh0WdcSpYkWeBHem2 No map is showing up at the top of some of the project pages: https://deploy-preview-1955--regen-registry.netlify.app/project/C02-016 or for example here there is a location but the map is blank: https://monosnap.com/file/sWiau7inTsnbqJxMqv0HvzhWSTLpb5 |
@blushi i used a fresh clone of the regen-web repo just in case, but even after doing that and running this sequence of commands i'm seeing some errors: Commands:
I.e. this storybook component works ok: but then for "tx successful modal" i'm seeing this: |
Similarly for the image storybook component i'm seeing: But the "action" component that @ryanchristo was having an issue with seems to be working OK for me: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tACK
The issues erika identified seem to be unrelated to the migration itself so we should track those items separately if we feel they need to be addressed.
I got storybook running in my local environment and am now seeing the same errors kyle identified but the image error seems to be working on the deploy preview.
If we can resolve the undefined buffer errors in the modal section, that would be the one new issue I see, but if this is blocking regen-network/rnd-dev-team#1537 and the solution is not straightforward, I'm ok with addressing in a followup.
This is on dev too, somehow the story is in the anchored metadata for this project (it should only be in the unanchored data), I suspect this might have occurred while developing/testing and is not related to the changes here.
This is on dev too, so probably we should open up a separate issue to fix this.
This was because we were missing the mapbox token in the env variables (since migrating to vite made us change the env variables names), it's fixed now. |
Found a workaround in the mean time but we can definitely fix this in a separate issue. See my comment in 3a4e765#diff-575d6b1c6b6f565f9b9037a316bbd68ab89898eeeab004bff7d6e79e0e512860R177-R179 |
Ok, will ignore for now.
Ok, I opened a task for this https://app.zenhub.com/workspaces/rnd-dev-team-5f8998bec8958d000f4609e2/issues/gh/regen-network/regen-registry/1762 |
Description
Closes: regen-network/rnd-dev-team#1316
Pending Storybook dev server fix.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...