Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update credit class page #1968

Merged
merged 2 commits into from
Jul 13, 2023
Merged

Conversation

flagrede
Copy link
Collaborator

@flagrede flagrede commented Jul 12, 2023

Description

Closes: regen-network/rnd-dev-team#1721

Added the following items to the credit class page:

  • credit type
  • credit offset generation methods
  • credit class tooltip

Also, refactor some old queries to react-query.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. Single offset method: https://deploy-preview-1968--regen-registry.netlify.app/credit-classes/C02
  2. Several offset methods: https://deploy-preview-1968--regen-registry.netlify.app/credit-classes/C01

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@netlify
Copy link

netlify bot commented Jul 12, 2023

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 2ee7725
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/64afaf7327d02a00082f2a7e
😎 Deploy Preview https://deploy-preview-1968--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flagrede
Copy link
Collaborator Author

@erikalogie you can test the credit class page update (type, offset methods, tooltip). I've put the links in the description.

@flagrede flagrede requested a review from a team July 12, 2023 08:19
@erikalogie
Copy link
Collaborator

@erikalogie you can test the credit class page update (type, offset methods, tooltip). I've put the links in the description.

LGTM!

Copy link
Member

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.

@flagrede flagrede force-pushed the feat-1721-update-credit-class-page branch from 4668af5 to 2ee7725 Compare July 13, 2023 08:01
@flagrede flagrede merged commit 012a4b1 into dev Jul 13, 2023
14 checks passed
@flagrede flagrede deleted the feat-1721-update-credit-class-page branch July 13, 2023 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add credit type, offset generation method, and "credit class" tooltip to credit class pages
3 participants