Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add local dev docker setup #1975

Merged
merged 9 commits into from
Aug 10, 2023
Merged

chore: add local dev docker setup #1975

merged 9 commits into from
Aug 10, 2023

Conversation

ryanchristo
Copy link
Member

@ryanchristo ryanchristo commented Jul 19, 2023

Description

This pull request includes a local development environment setup using docker.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

pg_dump [DATABASE_URL] --file dump-server-production -F c
docker-compose up
yarn start

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@netlify
Copy link

netlify bot commented Jul 19, 2023

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit eb97250
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/64d2a9b726096700085f77b5
😎 Deploy Preview https://deploy-preview-1975--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ryanchristo ryanchristo marked this pull request as ready for review August 8, 2023 22:06
@ryanchristo
Copy link
Member Author

This is ready for review. I've been using this for both regen-web and groups-ui. We can iterate on it over time and open to initial feedback but this seems like a good starting point to me.

@ryanchristo ryanchristo requested a review from a team August 8, 2023 22:07
Copy link
Collaborator

@flagrede flagrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing that, code looks good.
Not sure I will have time to test that soon but it's not blocking for merging as it won't break anything and we can iterate on it if needed.

@ryanchristo ryanchristo merged commit 07a0e74 into dev Aug 10, 2023
14 checks passed
@ryanchristo ryanchristo deleted the ryan/docker branch August 10, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants