Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: explore msw storybook addon PoC #2228

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
Draft

Conversation

blushi
Copy link
Member

@blushi blushi commented Nov 28, 2023

Description

ref: #2195


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Nov 28, 2023

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 93e8176
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/65670227405dd70008dac6e6
😎 Deploy Preview https://deploy-preview-2228--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

msw: {
handlers: [
sanity.query('AllCreditClass', req => {
console.log('sanity AllCreditClass');
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesn't get intercepted for some reason, we instantiate a new apollo client for it instead of using the client from the provider (which is set to the regen-server /graphql) so maybe that's the reason

@blushi blushi requested a review from a team November 28, 2023 15:57
@@ -0,0 +1 @@
export const handlers = [];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here we would add request handlers, similarly to the ones I've set up in the .stories.tsx below

@blushi blushi changed the title chore: explore msw storybook addon chore: explore msw storybook addon PoC Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant