Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APP-194 add prev/next post functionality #2398

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

blushi
Copy link
Member

@blushi blushi commented Jun 24, 2024

Description

https://regennetwork.atlassian.net/browse/APP-194?atlOrigin=eyJpIjoiNzM5NzkzNmI1M2VkNDI2Zjg0ZjFmZDA1YjE1MWIxNmUiLCJwIjoiaiJ9


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

https://deploy-preview-2398--regen-marketplace.netlify.app

  1. Navigate through posts for a project using prev/next buttons, from https://deploy-preview-2398--regen-marketplace.netlify.app/post/regen:13toVgkbviJfqjXYKLoqWt4WAigAYXLLjvYBB1wxB4uoukNM9LVVXT3.rdf. You shouldn't see any private posts.
  2. Log in and access one of your post page, you should be able to navigate to a private post using prev or next button.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 9392e80
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/66b5135b1cdc3e0008aefcc3
😎 Deploy Preview https://deploy-preview-2398--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi blushi marked this pull request as draft June 27, 2024 08:02
@blushi blushi force-pushed the feat-APP-194-post-prev-next branch from 9149650 to 150ff17 Compare July 17, 2024 11:07
@blushi blushi marked this pull request as ready for review July 18, 2024 08:35
@blushi blushi requested review from wgardiner and a team July 18, 2024 08:49
@blushi
Copy link
Member Author

blushi commented Jul 18, 2024

@erikalogie see testing instructions

@erikalogie
Copy link
Collaborator

When I'm on this page and click the "back" button I get this error
Screenshot 2024-07-18 at 10 36 53 AM

@blushi
Copy link
Member Author

blushi commented Jul 30, 2024

When I'm on this page and click the "back" button I get this error Screenshot 2024-07-18 at 10 36 53 AM

Looks like the post has been deleted since you tested so I get 404. I've identified somewhere in the code that could fix this. Could you test again with some other posts?

@blushi blushi force-pushed the feat-APP-194-post-prev-next branch from 33b92b0 to 2632ce6 Compare July 30, 2024 11:24
@erikalogie
Copy link
Collaborator

erikalogie commented Jul 30, 2024

I'm noticing a few things:

  1. The location of the next button should not change even if there is no previous
Regen Marketplace 2024-07-30 09-20-47
  1. If I'm on this post for example from 2023, and hit next, I go to the most recent post of 2024, instead of the oldest post from 2024, which would be the next post in chronological order: https://deploy-preview-2398--regen-marketplace.netlify.app/post/regen:13toVhd6kXzoVJ43rZw7baajAzAj9W4W5tVnaysv5mvyYDhgGaFSD1F.rdf

  2. If I'm on this page, I can navigate to a post that has been deleted, which shouldn't be the case: https://deploy-preview-2398--regen-marketplace.netlify.app/project/kasigau

@blushi
Copy link
Member Author

blushi commented Jul 31, 2024

  1. The location of the next button should not change even if there is no previous

Fixed.

  1. If I'm on this post for example from 2023, and hit next, I go to the most recent post of 2024, instead of the oldest post from 2024, which would be the next post in chronological order: https://deploy-preview-2398--regen-marketplace.netlify.app/post/regen:13toVhd6kXzoVJ43rZw7baajAzAj9W4W5tVnaysv5mvyYDhgGaFSD1F.rdf

This will require a fix at the server side I believe, will let you know once that's done.

  1. If I'm on this page, I can navigate to a post that has been deleted, which shouldn't be the case: https://deploy-preview-2398--regen-marketplace.netlify.app/project/kasigau

How do you know the post has been deleted? The fact that it doesn't appear on the timeline is because I've changed our API and we need to merge #2409 first for the timeline to work normally.

@blushi
Copy link
Member Author

blushi commented Aug 5, 2024

3. If I'm on this post for example from 2023, and hit next, I go to the most recent post of 2024, instead of the oldest post from 2024, which would be the next post in chronological order: https://deploy-preview-2398--regen-marketplace.netlify.app/post/regen:13toVhd6kXzoVJ43rZw7baajAzAj9W4W5tVnaysv5mvyYDhgGaFSD1F.rdf

This will require a fix at the server side I believe, will let you know once that's done.

Ready to test

@erikalogie
Copy link
Collaborator

  1. If I'm on this post for example from 2023, and hit next, I go to the most recent post of 2024, instead of the oldest post from 2024, which would be the next post in chronological order: https://deploy-preview-2398--regen-marketplace.netlify.app/post/regen:13toVhd6kXzoVJ43rZw7baajAzAj9W4W5tVnaysv5mvyYDhgGaFSD1F.rdf

This will require a fix at the server side I believe, will let you know once that's done.

Ready to test

LGTM

@erikalogie
Copy link
Collaborator

  1. If I'm on this page, I can navigate to a post that has been deleted, which shouldn't be the case: https://deploy-preview-2398--regen-marketplace.netlify.app/project/kasigau

How do you know the post has been deleted? The fact that it doesn't appear on the timeline is because I've changed our API and we need to merge #2409 first for the timeline to work normally.

Just tested this and seems to work correctly

@erikalogie
Copy link
Collaborator

One new issue I did spot in testing just now on this project's data stream: https://deploy-preview-2398--regen-marketplace.netlify.app/project/kasigau, is that you can click previous and go to posts that do not appear on the data stream itself. Sending you a video via slack as it is not uploading to github.

@blushi blushi force-pushed the feat-APP-194-post-prev-next branch from 2e2edad to e5abcb3 Compare August 7, 2024 10:16
@blushi
Copy link
Member Author

blushi commented Aug 8, 2024

@erikalogie could you test this again?

@erikalogie
Copy link
Collaborator

Working now! LGTM

@blushi blushi force-pushed the feat-APP-194-post-prev-next branch from e5abcb3 to 9392e80 Compare August 8, 2024 18:50
@blushi blushi enabled auto-merge (squash) August 8, 2024 18:50
@blushi blushi merged commit 7ba2017 into dev Aug 8, 2024
11 of 14 checks passed
@blushi blushi deleted the feat-APP-194-post-prev-next branch August 8, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants