Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APP-189 post secret link #2401

Merged
merged 6 commits into from
Jul 15, 2024
Merged

feat: APP-189 post secret link #2401

merged 6 commits into from
Jul 15, 2024

Conversation

blushi
Copy link
Member

@blushi blushi commented Jun 27, 2024

Description

https://regennetwork.atlassian.net/browse/APP-189?atlOrigin=eyJpIjoiYWRjMDY0MWRmNWQwNGUwYmEzZmRkOThjZTVhNzdiZmYiLCJwIjoiaiJ9


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

From https://deploy-preview-2401--regen-marketplace.netlify.app/post/regen:13toVg8bPSA85BdNcn7GibTNUoFD25q9krJRV7sWr2qPhyySgHMDv1A.rdf?token=7bbd0a3d7fde9293d9d1dcdb5b91284c

  1. Create a post which private or has private files or locations (or use an existing one for a project you're an admin of) and go the post page while being logged in, you should have an option to share a secret link from the top right button "...".
  2. Log out and use the copied secret link to access the post page, you should see all post info
  3. Create a public post (or use an existing one for a project you're an admin of) and go to the post page while being logged in, the secret link option shouldn't be available.
  4. Share one of your posts with some private data from the project data stream section

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Jun 27, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 65f8b62
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/6694ce5b985645000847d5f1
😎 Deploy Preview https://deploy-preview-2401--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi blushi marked this pull request as ready for review July 4, 2024 08:08
@blushi blushi force-pushed the feat-APP-189-post-secret-link branch from eb4a6c6 to 46f65ff Compare July 4, 2024 08:08
@blushi blushi requested review from clevinson, wgardiner and a team July 4, 2024 11:02
@blushi
Copy link
Member Author

blushi commented Jul 4, 2024

@erikalogie @clevinson see testing instructions 1 to 3.
will ping you once 4 is ready

@erikalogie
Copy link
Collaborator

LGTM! I sent you a few comments on slack about the color of the three dot icon and a new share secret icon that is all one color

@blushi blushi force-pushed the feat-APP-189-post-secret-link branch from 46f65ff to dab681c Compare July 9, 2024 09:44
@blushi
Copy link
Member Author

blushi commented Jul 9, 2024

LGTM! I sent you a few comments on slack about the color of the three dot icon and a new share secret icon that is all one color

@erikalogie updated
You can also test 4. (from your project data stream section)

@erikalogie
Copy link
Collaborator

This works well! Will your replace the share icon with this one so that the share and secret link icons are the same shade of green?
Share

@blushi
Copy link
Member Author

blushi commented Jul 10, 2024

This works well! Will your replace the share icon with this one so that the share and secret link icons are the same shade of green? Share

updated the existing icon color, no need to replace it entirely

Copy link
Contributor

@r41ph r41ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@blushi blushi force-pushed the feat-APP-189-post-secret-link branch from 46b7a76 to 65f8b62 Compare July 15, 2024 07:23
@blushi blushi merged commit be1e1e6 into dev Jul 15, 2024
14 checks passed
@blushi blushi deleted the feat-APP-189-post-secret-link branch July 15, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants