feat: APP-195 files preview #2403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
@clevinson @erikalogie I still need to address the TODO mentioned in the PR description (pending some other work to be merged) but you can already follow the testing instructions to see the files preview from storybook |
blushi
commented
Jul 4, 2024
| @@ -11,8 +11,6 @@ export * from './OptimizedImage'; | |||
| export * from './PeerReviewed'; | |||
| export * from './PeerReviewed'; | |||
| export * from './ProcessStepCard'; | |||
| export * from './ProtectedRoute'; | |||
There was a problem hiding this comment.
unrelated, just some clean up
|
This looks awesome |
blushi
force-pushed
the
feat-APP-195-files-preview
branch
from
a8347ca
to
dcde0dd
Compare
|
@erikalogie you can test the file previews on the data stream section as well now: https://deploy-preview-2403--regen-marketplace.netlify.app/project/test-project123 |
|
@blushi if there is only one file, then the icon isn't necessary 
|
@erikalogie fixed |
|
Ok great, LGTM! |
blushi
force-pushed
the
feat-APP-195-files-preview
branch
from
02aab39
to
1e65e87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://regennetwork.atlassian.net/browse/APP-195?atlOrigin=eyJpIjoiYmIyYjMyYjRiMGEyNGJiNjllZjYyMGNkZGJiNDVmNDQiLCJwIjoiaiJ9
Also fixes https://regennetwork.atlassian.net/browse/APP-210
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Check the files previews on:
https://deploy-preview-2403--regen-storybook.netlify.app/?path=/story/organisms-postfiles--public
https://deploy-preview-2403--regen-storybook.netlify.app/?path=/story/organisms-postfiles--private-locations
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...