-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: APP-202 buy credits step 2 #2418
Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
web-storybook/.storybook/main.js
Outdated
// react({ | ||
// babel: { | ||
// plugins: ['macros'], | ||
// }, | ||
// }), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had to comment this temporarily, it's causing some issues running storybook locally
will need to investigate further cc/ @flagrede
reverted it back so the storybook build work
// import { msg, Trans } from '@lingui/macro'; | ||
// import { useLingui } from '@lingui/react'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO use lingui once issue running storybook locally is fixed
temporary fix is to do the following #2418 (comment)
@erikalogie @clevinson see testing instructions |
@erikalogie done |
LGTM! |
web-marketplace/src/components/organisms/PaymentInfoForm/PaymentInfoForm.CustomerInfo.tsx
Outdated
Show resolved
Hide resolved
web-marketplace/src/components/organisms/PaymentInfoForm/PaymentInfoForm.tsx
Outdated
Show resolved
Hide resolved
web-marketplace/src/components/organisms/PaymentInfoForm/PaymentInfoForm.tsx
Outdated
Show resolved
Hide resolved
d490238
to
b207fdc
Compare
Description
https://regennetwork.atlassian.net/browse/APP-202?atlOrigin=eyJpIjoiMGZmODlhMTc4YTY5NGYxNWJmZWM3MWE0MDYzNTNmNDAiLCJwIjoiaiJ9
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
https://deploy-preview-2418--regen-storybook.netlify.app/?path=/story/marketplace-organisms-paymentinfoform--fiat-logged-out
https://deploy-preview-2418--regen-storybook.netlify.app/?path=/story/marketplace-organisms-paymentinfoform--fiat-logged-in-no-email
https://deploy-preview-2418--regen-storybook.netlify.app/?path=/story/marketplace-organisms-paymentinfoform--fiat-logged-in-with-email
https://deploy-preview-2418--regen-storybook.netlify.app/?path=/story/marketplace-organisms-paymentinfoform--fiat-logged-in-with-payment-method
https://deploy-preview-2418--regen-storybook.netlify.app/?path=/story/marketplace-organisms-paymentinfoform--crypto-no-email
https://deploy-preview-2418--regen-storybook.netlify.app/?path=/story/marketplace-organisms-paymentinfoform--crypto-with-email
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...