Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APP-203 buy credits step 3 #2419

Merged
merged 8 commits into from
Aug 8, 2024
Merged

feat: APP-203 buy credits step 3 #2419

merged 8 commits into from
Aug 8, 2024

Conversation

blushi
Copy link
Member

@blushi blushi commented Jul 31, 2024

Description

https://regennetwork.atlassian.net/browse/APP-203?atlOrigin=eyJpIjoiMGQ4YWNlYzVkYzg1NGFkYmI0MTZkMjRmZWE0ZTg3NGQiLCJwIjoiaiJ9


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

https://deploy-preview-2419--regen-storybook.netlify.app/?path=/story/marketplace-organisms-agreepurchaseform--retirement
https://deploy-preview-2419--regen-storybook.netlify.app/?path=/story/marketplace-organisms-agreepurchaseform--no-retirement

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Jul 31, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 04d68b4
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/66b4c03043769100083c401a
😎 Deploy Preview https://deploy-preview-2419--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@blushi blushi requested review from a team July 31, 2024 08:57
@blushi
Copy link
Member Author

blushi commented Jul 31, 2024

@erikalogie @clevinson see testing instructions

@erikalogie
Copy link
Collaborator

This looks awesome! I just provided you with a mobile version that is every so slightly different (smaller paragraph text and icon), but otherwise, this looks amazing! Sorry for not providing this earlier too: https://www.figma.com/design/BTuUv6QXY4GbliZcXCe8RJ/Fiat-payments?node-id=3979-86580&t=kJffMCY9IWXtRyzh-1

@blushi blushi requested a review from r41ph August 7, 2024 14:21
@blushi
Copy link
Member Author

blushi commented Aug 7, 2024

This looks awesome! I just provided you with a mobile version that is every so slightly different (smaller paragraph text and icon), but otherwise, this looks amazing! Sorry for not providing this earlier too: https://www.figma.com/design/BTuUv6QXY4GbliZcXCe8RJ/Fiat-payments?node-id=3979-86580&t=kJffMCY9IWXtRyzh-1

Could you have another look @erikalogie ?

@erikalogie
Copy link
Collaborator

It looks kind of cut off at smaller viewports:

Screenshot 2024-08-07 at 1 47 32 PM

@blushi
Copy link
Member Author

blushi commented Aug 8, 2024

It looks kind of cut off at smaller viewports

@erikalogie ready for another look

@erikalogie
Copy link
Collaborator

LGTM

@blushi blushi enabled auto-merge (squash) August 8, 2024 12:55
@blushi blushi merged commit 9eac1f0 into dev Aug 8, 2024
12 of 14 checks passed
@blushi blushi deleted the feat-APP-203-buy-step-3 branch August 8, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants