-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: APP-183 attach signature to data post + APP-240 #2423
Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@erikalogie @clevinson see testing instructions |
@blushi when creating the post from the profile/projects page with a web 2.0 account, I never got the success modal though the post was successfully created For the web 3.0 accounts, the signing modal looks like this and then I also don't get the success modal: |
@erikalogie could you test this again? |
It is working well for me now! Just double-check the font size for the hashes in the confirmation popup after a user has signed, does not match the comps or the other confirmation popups. |
aab9228
to
1e1c331
Compare
@erikalogie could you have another look? |
This looks great! I just have a few copy suggestions. When no signature is provided, there's no title in the modal that pops up. Additionally I think the "Attest" title should be a bit more clear. Can we instead have the title always say "Create Data Post", similar to how when creating a project it says "Create Project" Then, in the section below I think we should change the following:
I think those will be more clear to non web3 users. @erikalogie @blushi let me know what y'all think? In general I think we can leave "Anchor" and "Attest" out of the marketplace UIs, and have them only appears in API documentation and Mintscan. |
All sounds good to me. If we are going to change "hash" here then we should probably change it on all the other confirmation popups too for consistency. |
1e1c331
to
4de620c
Compare
@erikalogie @clevinson ready for another review, I've applied the copy suggestions. |
@clevinson @erikalogie we also now have this "NOTE: As posts are anchored to the blockchain, they are not editable once published" at the bottom of the post creation form. Should we rephrase it to get rid of "anchored"? |
Yes, I think @clevinson will likely have a good suggestion here. |
|
Sorry this is when I forget to generate the .po files for the translation now that we have it set up in the app. I'll fix that. |
4de620c
to
7e68787
Compare
@erikalogie this should be fixed now |
1a83a91
to
ee2e9af
Compare
LGTM |
ee2e9af
to
11f1037
Compare
Description
https://regennetwork.atlassian.net/browse/APP-183?atlOrigin=eyJpIjoiYTczMWFmNjQ1NjhkNGU2Y2FiYTk2NzYzM2E5YWJkMjIiLCJwIjoiaiJ9
https://regennetwork.atlassian.net/browse/APP-240?atlOrigin=eyJpIjoiZmNkYmEwMTIwNjM0NGM5MjlhZjhmNGUxN2JjZmYwMzMiLCJwIjoiaiJ9
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
From https://deploy-preview-2423--regen-marketplace.netlify.app/
The button at the bottom of the success modal now goes to the newly created post page.
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...