-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: APP-324 Tebu Banner #2485
Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@erikalogie You can have a look at the Tebu Banner here: https://deploy-preview-2485--regen-marketplace.netlify.app/projects/1 |
@@ -29,7 +29,6 @@ VITE_BRIDGE = "true" | |||
VITE_SKIPPED_CLASS_ID = "" | |||
|
|||
[context.deploy-preview.environment] | |||
VITE_SANITY_TAG = "default" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have moved this variable to Netlify so we can override it in Netlify for a specific branch.
d396d8c
to
e5b8fca
Compare
Let's save the closed state in local storage. This looks great! Just two small design things: the card background should be white and the paragraph text should be 14px on mobile. |
Also let's reduce the space above and below the component on mobile: See this comp for more clarity on that: https://www.figma.com/design/brkxGV5qNOkZUp0YQl1cxO/Terrasos-Phase-1?node-id=708-86974&t=BLbnCULySCl3T9L2-1 |
@erikalogie I have handled your feedback. |
LGTM! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
3acef6f
to
b480b0f
Compare
Description
Add the Tebu Banner component and use it on the projects page.
Sanity PR: regen-network/regen-sanity#67
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...