Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APP-324 Tebu Banner #2485

Merged
merged 8 commits into from
Oct 1, 2024
Merged

feat: APP-324 Tebu Banner #2485

merged 8 commits into from
Oct 1, 2024

Conversation

flagrede
Copy link
Collaborator

@flagrede flagrede commented Sep 25, 2024

Description

Add the Tebu Banner component and use it on the projects page.

Sanity PR: regen-network/regen-sanity#67


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Sep 25, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit b480b0f
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/66fbac23a6144c00089a45d1
😎 Deploy Preview https://deploy-preview-2485--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@flagrede
Copy link
Collaborator Author

@erikalogie You can have a look at the Tebu Banner here: https://deploy-preview-2485--regen-marketplace.netlify.app/projects/1
Should we save the closed state in local storage so we can hide the banner on further visits, or should we reopen it every time?

@@ -29,7 +29,6 @@ VITE_BRIDGE = "true"
VITE_SKIPPED_CLASS_ID = ""

[context.deploy-preview.environment]
VITE_SANITY_TAG = "default"
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have moved this variable to Netlify so we can override it in Netlify for a specific branch.

@erikalogie
Copy link
Collaborator

@erikalogie You can have a look at the Tebu Banner here: https://deploy-preview-2485--regen-marketplace.netlify.app/projects/1 Should we save the closed state in local storage so we can hide the banner on further visits, or should we reopen it every time?

Let's save the closed state in local storage.

This looks great! Just two small design things: the card background should be white and the paragraph text should be 14px on mobile.

@erikalogie
Copy link
Collaborator

Also let's reduce the space above and below the component on mobile:
Monosnap Regen Marketplace 2024-09-26 11-37-38

See this comp for more clarity on that: https://www.figma.com/design/brkxGV5qNOkZUp0YQl1cxO/Terrasos-Phase-1?node-id=708-86974&t=BLbnCULySCl3T9L2-1

@flagrede
Copy link
Collaborator Author

@erikalogie I have handled your feedback.

@erikalogie
Copy link
Collaborator

@erikalogie I have handled your feedback.

LGTM!

Copy link
Contributor

@wgardiner wgardiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@flagrede flagrede merged commit 61ba690 into dev Oct 1, 2024
14 checks passed
@flagrede flagrede deleted the feat-APP-324-tebu-banner branch October 1, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants