-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: APP-322 terassos project filters UI #2487
Conversation
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
15faeb1
to
5383368
Compare
@wgardiner you can use the draft PR feature from github here if you think that's still a draft |
b699b7b
to
26002ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work on this PR, the UI looks nice!
Left a few comments, the biggest thing might be that the PR heavily rely on MUI instead of tailwind. We want to get rid of MUI in the long term so new components should not introduce new usage of MUI.
If this is too much of a pain to rewrite it for this PR, it's ok to leave it as it is but for new components it would be best to favor tailwind usage.
web-components/src/components/icons/terassos/ColombiaRegionIcon/ColombiaRegionIcon.tsx
Outdated
Show resolved
Hide resolved
web-components/src/components/icons/terassos/ColombiaRegionIcon/ColombiaRegionIcon.tsx
Outdated
Show resolved
Hide resolved
web-components/src/components/icons/terassos/ColombiaRegionIcon/ColombiaRegionIcon.tsx
Outdated
Show resolved
Hide resolved
web-components/src/components/icons/terassos/ColombiaRegionIcon/ColombiaRegionIcon.tsx
Outdated
Show resolved
Hide resolved
web-components/src/components/icons/terassos/ColombiaRegionIcon/ColombiaRegionIcon.tsx
Outdated
Show resolved
Hide resolved
web-components/src/components/icons/terassos/ComplianceBadge.tsx
Outdated
Show resolved
Hide resolved
web-components/src/components/organisms/ProjectFilters/ProjectFilter.TagFilter.tsx
Outdated
Show resolved
Hide resolved
web-components/src/components/organisms/ProjectFilters/ProjectFilters.tsx
Outdated
Show resolved
Hide resolved
a77969d
to
9a75cac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
…or ColombiaRegionIcon, migrate MUI styling to tailwind
9a75cac
to
ee69946
Compare
Description
Closes: APP-322
This PR adds UI for Terassos project filters and an approach for customizing color SVG colors
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...