Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: APP-347 get rid of buy buttons and sell orders page in main nav #2488

Conversation

r41ph
Copy link
Contributor

@r41ph r41ph commented Sep 30, 2024

Description

https://regennetwork.atlassian.net/browse/APP-347


Author Checklist

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

https://deploy-preview-2488--regen-marketplace.netlify.app/storefront

  1. Verify that the Trade item in the main navigation is not present.
  2. When logged in go to /storefront and check that the Buy button is no present in the Actions column but the Cancel option is still available.
  3. When not logged in go to /storefront and check that the Actions column is not visible.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Sep 30, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit e7f254d
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/6703f32440b83300072a55b4
😎 Deploy Preview https://deploy-preview-2488--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@r41ph
Copy link
Contributor Author

r41ph commented Sep 30, 2024

@Erika see testing instructions

@r41ph r41ph requested a review from blushi September 30, 2024 13:30
Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving, pending some remaining clean up

);
}
: undefined
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can also get rid of BuyCreditsModal and related code: isBuyModalOpen, etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing that out

@r41ph r41ph force-pushed the feat-APP-347-get-rid-of-buy-buttons-and-sell-orders-page-in-main-nav branch from db4de8d to a33e091 Compare October 3, 2024 09:16
@r41ph r41ph requested a review from blushi October 3, 2024 14:53
@blushi
Copy link
Member

blushi commented Oct 7, 2024

@Erika see testing instructions

@r41ph looks like you didn't tag the right @erikalogie
@erikalogie could you have a look?

@erikalogie
Copy link
Collaborator

This looks good, I would just get rid of this shadow when there are no actions in the logged out version

Monosnap Regen Marketplace 2024-10-07 09-45-00

@r41ph
Copy link
Contributor Author

r41ph commented Oct 7, 2024

This looks good, I would just get rid of this shadow when there are no actions in the logged out version

Ah ok I'll remove it. I thought that was part of the design, like a 'hint' for letting users know there's more table to scroll horizontally.

@r41ph r41ph force-pushed the feat-APP-347-get-rid-of-buy-buttons-and-sell-orders-page-in-main-nav branch from b15c90b to e7f254d Compare October 7, 2024 14:41
@r41ph
Copy link
Contributor Author

r41ph commented Oct 7, 2024

@erikalogie I have removed the shadow, please have a look

@erikalogie
Copy link
Collaborator

LGTM!

@blushi blushi merged commit 664b9c5 into dev Oct 9, 2024
14 checks passed
@blushi blushi deleted the feat-APP-347-get-rid-of-buy-buttons-and-sell-orders-page-in-main-nav branch October 9, 2024 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants