Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make provider import dynamic #2492

Merged
merged 1 commit into from
Oct 1, 2024
Merged

fix: make provider import dynamic #2492

merged 1 commit into from
Oct 1, 2024

Conversation

flagrede
Copy link
Collaborator

@flagrede flagrede commented Oct 1, 2024

Description

Make providers import lazy to avoid conflicts in CSS imports.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

@flagrede flagrede requested a review from blushi October 1, 2024 14:35
Copy link

netlify bot commented Oct 1, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit 1d732a1
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/66fc089451a9eb000897342e
😎 Deploy Preview https://deploy-preview-2492--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tACK

@flagrede flagrede merged commit d016f29 into dev Oct 1, 2024
14 checks passed
@flagrede flagrede deleted the fix-theme-provider branch October 1, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants