Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: WWW-6 update newsletter subscription url #2502

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

r41ph
Copy link
Contributor

@r41ph r41ph commented Oct 15, 2024

Description

https://regennetwork.atlassian.net/browse/WWW-6

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • provided a link to the relevant issue or specification
  • provided instructions on how to test
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

How to test

  1. Go to https://deploy-preview-2502--regen-website.netlify.app/ and at the bottom of the page chack that the subscription form works as expected.

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items
.

I have...

  • confirmed all author checklist items have been addressed
  • reviewed code correctness and readability
  • verified React components follow DRY principles
  • reviewed documentation is accurate
  • reviewed tests
  • manually tested (if applicable)

Copy link

netlify bot commented Oct 15, 2024

Deploy Preview for regen-website ready!

Name Link
🔨 Latest commit c502c84
🔍 Latest deploy log https://app.netlify.com/sites/regen-website/deploys/670e25a53da352000812f05a
😎 Deploy Preview https://deploy-preview-2502--regen-website.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@r41ph r41ph requested a review from blushi October 15, 2024 08:34
@r41ph
Copy link
Contributor Author

r41ph commented Oct 15, 2024

@erikalogie see testing instructions

Copy link
Member

@blushi blushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@erikalogie
Copy link
Collaborator

LGTM!

@r41ph r41ph merged commit c4a9ae3 into dev Oct 15, 2024
14 checks passed
@r41ph r41ph deleted the fix-WWW-6-subscribe-to-newsletter-not-working branch October 15, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants