feat: filter projects by type #2510
Open
+24
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for regen-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
flagrede
force-pushed
the
feat-APP-376-filter-terrasos-projects
branch
from
86de3f4
to
d5eb83a
Compare
blushi
requested changes
Oct 23, 2024
web-marketplace/src/lib/normalizers/projects/normalizeProjectsWithMetadata.ts
Outdated
Show resolved
Hide resolved
flagrede
force-pushed
the
feat-APP-376-filter-terrasos-projects
branch
from
4f62e8b
to
1c3675f
Compare
blushi
reviewed
Oct 24, 2024
| @@ -149,18 +149,30 @@ export function useProjectsWithOrders({ | |||
| projects = projectsData?.projects; | |||
| } | |||
|
|
|||
| const offChainIds = allOffChainProjects.map(project => project.id); | |||
| const clientProjects = projects?.filter(project => | |||
| IS_TERRASOS ? offChainIds.includes(project.id) : true, | |||
There was a problem hiding this comment.
we are comparing off chain uuids to on chain project ids here, why?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: APP-376
Filter Terrasos projects by type.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
How to test
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...