Add Constant Domain History #962
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new 'Constant Domain History' object.
Why
Currently when navigating back and forth with the history object, you don't know upfront where this will bring you. So you might as well end up on a different domain, which is often unexpected / unwanted.
What
The newly added history object prevents going back to a different domain.
How
By setting a
fromDomainflag in the history state. See the extended docs in this PR for further details.Impact
It slightly modifies the existing interface of the History object, but it is still backwards compatible. The navigation functions now return a boolean if the navigation was blocked or not.
State
This is an initial PR, I don't expect it to get merged as is, but I'd love to gain some feedback / insights from the community!