Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config/inherit): resolve presets #31642

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

fix(config/inherit): resolve presets #31642

wants to merge 19 commits into from
+187 −2

Conversation

RahulGautamSingh
Copy link
Collaborator

@RahulGautamSingh RahulGautamSingh commented Sep 26, 2024 •
edited by viceice
Loading

Changes

Resolve presets present in inherited config

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

@RahulGautamSingh RahulGautamSingh marked this pull request as draft September 26, 2024 16:30
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review September 27, 2024 19:49
HonkingGoose
HonkingGoose suggested changes Sep 30, 2024
View reviewed changes
docs/usage/config-overview.md Outdated Show resolved Hide resolved
docs/usage/config-overview.md Outdated Show resolved Hide resolved
lib/workers/repository/init/inherited.spec.ts Show resolved Hide resolved
@HonkingGoose

This comment was marked as resolved.

Sign in to view
secustor
secustor reviewed Oct 2, 2024
View reviewed changes
lib/workers/repository/init/inherited.ts Outdated Show resolved Hide resolved
lib/workers/repository/init/inherited.ts Outdated Show resolved Hide resolved
lib/workers/repository/init/inherited.ts Outdated Show resolved Hide resolved
HonkingGoose
HonkingGoose suggested changes Oct 7, 2024
View reviewed changes
lib/workers/repository/init/inherited.ts Outdated Show resolved Hide resolved
lib/workers/repository/init/inherited.ts Outdated Show resolved Hide resolved
@RahulGautamSingh @HonkingGoose
Apply suggestions from code review
b01e062 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
HonkingGoose
HonkingGoose reviewed Oct 9, 2024
View reviewed changes
docs/usage/config-overview.md Outdated Show resolved Hide resolved
docs/usage/config-overview.md Show resolved Hide resolved
@RahulGautamSingh @HonkingGoose
Apply suggestions from code review
139fced 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
rarkins and others added 2 commits October 11, 2024 12:11
@rarkins @HonkingGoose
Update docs/usage/config-overview.md
716c1a6 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@rarkins
update
d697f48
rarkins
rarkins requested changes Oct 11, 2024
View reviewed changes
Copy link
Collaborator

@rarkins rarkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Drop support for npm presets in inheritedConfig

lib/workers/repository/init/inherited.ts Outdated Show resolved Hide resolved
rarkins
rarkins requested changes Oct 17, 2024
View reviewed changes
docs/usage/config-overview.md Outdated Show resolved Hide resolved
docs/usage/config-overview.md Outdated Show resolved Hide resolved
lib/workers/repository/init/inherited.ts Outdated Show resolved Hide resolved
lib/workers/repository/init/inherited.ts Outdated Show resolved Hide resolved
HonkingGoose
HonkingGoose suggested changes Oct 17, 2024
View reviewed changes
Copy link
Collaborator

@HonkingGoose HonkingGoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small additions to @rarkins's suggestions.

docs/usage/config-overview.md Outdated Show resolved Hide resolved
docs/usage/config-overview.md Outdated Show resolved Hide resolved
docs/usage/config-overview.md Outdated Show resolved Hide resolved
viceice
viceice reviewed Nov 8, 2024
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see open conversations, otherwise LGTM

RahulGautamSingh and others added 2 commits November 8, 2024 15:00
@RahulGautamSingh @HonkingGoose
Apply suggestions from code review
a10a6e9 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@RahulGautamSingh
Merge branch 'main' into fix/inherit-config
57bd893
HonkingGoose
HonkingGoose suggested changes Nov 8, 2024
View reviewed changes
docs/usage/config-overview.md Outdated Show resolved Hide resolved
RahulGautamSingh and others added 2 commits November 8, 2024 15:29
@RahulGautamSingh @HonkingGoose
Update docs/usage/config-overview.md
7b1c1f1 
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
@RahulGautamSingh
apply suggestinos
ffc888e
secustor
secustor previously approved these changes Nov 8, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HonkingGoose HonkingGoose HonkingGoose approved these changes

@viceice viceice viceice approved these changes

@secustor secustor secustor left review comments

@rarkins rarkins Awaiting requested review from rarkins

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inherited config should be resolved before merging
5 participants
@RahulGautamSingh @HonkingGoose @viceice @rarkins @secustor