Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): allow multiple branch/pr limits #32556

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

RahulGautamSingh
Copy link
Collaborator

Changes

Allows concurrent and hourly limits to be set in package rules. (implemented everything mentioned in this comment)

Context

Closes: #10546

Documentation (please check one with an [x])

  • I have updated the documentation, or (required will add after review of code)
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository (Tested both old and new behaviour)

Old Behaviour: follows hourly limits, 1, 2, 3
New Behaviour 1, 2, 3

Note: Test descriptions present in readme of each test repo

@RahulGautamSingh RahulGautamSingh marked this pull request as draft November 15, 2024 03:20
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review November 15, 2024 04:38
@RahulGautamSingh RahulGautamSingh marked this pull request as draft November 15, 2024 04:52
@RahulGautamSingh RahulGautamSingh marked this pull request as ready for review November 15, 2024 05:03
lib/workers/repository/update/branch/index.ts Outdated Show resolved Hide resolved
lib/workers/repository/process/limits.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.spec.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.ts Outdated Show resolved Hide resolved
lib/workers/repository/process/limits.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.ts Outdated Show resolved Hide resolved
lib/workers/repository/update/branch/index.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.ts Outdated Show resolved Hide resolved
lib/workers/global/limits.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow multiple branch/PR limit groups
4 participants