feat(datasource/maven): Use relocation information #32636
+83
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
astellingwerf
approved these changes
Nov 21, 2024
viceice
changed the title
viceice
reviewed
Nov 24, 2024
| relocation.valueWithPath('artifactId') ?? dependency.name; | ||
| result.replacementName = relocationGroup + ':' + relocationName; | ||
| const relocationVersion = relocation.valueWithPath('version'); | ||
| result.replacementVersion = relocationVersion ?? version; |
There was a problem hiding this comment.
skip version, do not set if not defined
There was a problem hiding this comment.
It would be wrong, if the version will not be set.
The documentation says the following:
If any of the values are omitted, it is assumed to be the same as it was before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the maven datasource part of #32550