Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bitbucket): release notes heading link #32693

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

setchy
Copy link
Collaborator

@setchy setchy commented Nov 23, 2024

Changes

Similar to #32689, release note heading hyperlinks for bitbucket should be src/ and not blob/

Context

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

Signed-off-by: Adam Setch <adam.setch@outlook.com>
@setchy setchy added platform:bitbucket Bitbucket Cloud platform core:changelogs Related to changelogs/release notes fetching labels Nov 23, 2024
@setchy setchy requested a review from rarkins November 23, 2024 17:22
@@ -479,3 +486,12 @@ export async function addReleaseNotes(
export function shouldSkipChangelogMd(repository: string): boolean {
return repositoriesToSkipMdFetching.includes(repository);
}

function getSourceRootPath(type: ChangeLogPlatform): string {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be part of platform API as told in other PR

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same reply #32689 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core:changelogs Related to changelogs/release notes fetching platform:bitbucket Bitbucket Cloud platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants