feat(schedule): replace later with cron
#32718
Open
+15
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rarkins
previously approved these changes
Nov 25, 2024
viceice
reviewed
Nov 25, 2024
viceice
changed the title
later with cronlater with cron
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
|
Ranges are inclusive. |
viceice
reviewed
Nov 25, 2024
| @@ -2464,7 +2464,7 @@ Here's an example config to limit the "noisy" `aws-sdk` package to weekly update | |||
| "packageRules": [ | |||
| { | |||
| "matchPackageNames": ["aws-sdk"], | |||
| "schedule": ["after 9pm on sunday"] | |||
| "schedule": ["* 21-23 * * 7"] | |||
There was a problem hiding this comment.
@rarkins should be we add a human readable description?
so this is effective 21:00 - 23:59
| const quarterly = ['* * * */3 *']; | ||
| const weekdays = ['* * * * 1-5']; | ||
| const weekends = ['* * * * 6,7']; | ||
| const yearly = ['* * 1 */12 *']; |
There was a problem hiding this comment.
we should add unit tests to ensure the textual representation matches our expectations.
There was a problem hiding this comment.
Yeah, I was thinking the same. On it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Replace all later scheduleing in docs & presets with their cron equivalent
Context
Closes: #32414
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: