Issue #422: Make --error-on-invalid-index the default behavior #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
za-arthur
reviewed
Nov 13, 2024
bin/pg_repack.c
Outdated
| /* Enforce --error-on-invalid-index in all cases unless | ||
| * --no_error_on_invalid_index passed by itself | ||
| */ | ||
| if (error_on_invalid_index || !no_error_on_invalid_index) { |
There was a problem hiding this comment.
Thanks for the PR! What if we completely ignore error_on_invalid_index here and make it no-op as it was suggested previously #422 (comment), but keep it as a valid option and document it as a no-op in the documentation? WDYT?
There was a problem hiding this comment.
Needs to stay as an option anyway. Can be marked as deprecated, and in 2-3 years can be removed.
There was a problem hiding this comment.
Yeah, I think this makes sense. Released an updated version, which makes --error-on-invalid-index no-op and marked it as deprecated in helper and docs.
There was a problem hiding this comment.
Thanks! I'd merge the PR if no objections.
Skipping repacking the invalid indexes could lead to corrupting the invalid indexes. In some rare cases, this might cause inserts to tables to fail as changes to a table continuously be applied to invalid indexes on it and updates to corrupted invalid indexes potentially might fail by the checks done during insertion. Therefore, by default do not repack a table with invalid indexes. Repack only user explicitly specifies --no-error-on-invalid-index.
zubeyr94
force-pushed
the
skip-table-with-invalid-index
branch
from
c81d575 to
55cfa77
Compare
|
@zubeyr94 I merged the PR. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skipping repacking the invalid indexes could lead to corrupting the invalid indexes. In some rare cases, this might cause inserts to tables to fail as changes to a table continuously be applied to invalid indexes on it and updates to corrupted invalid indexes potentially might fail by the checks done during insertion. Therefore, by default do not repack a table with invalid indexes. Repack only user explicitly specifies --no-error-on-invalid-index.