Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V 3/beta tweaks v3 #1316

Merged
merged 19 commits into from
Sep 7, 2023
Merged

V 3/beta tweaks v3 #1316

merged 19 commits into from
Sep 7, 2023

Conversation

svenvoskamp
Copy link
Contributor

@svenvoskamp svenvoskamp commented Sep 7, 2023 •
edited
Loading

Changes

  • fix: loader adjusts to master border-radius & scroll lock issue fix

@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
c9db2a3
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
797a677
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
5bb31c4
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
9d7d7fb
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
e4751ef
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
c283ab2
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
035cfef
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
44b0366
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
f00815b
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
482e54e
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
bf7059a
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
362f940
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
9b91647
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
83fa048
@svenvoskamp
Merge branch 'V3' of github.com:WalletConnect/web3modal into V3
b35eb4b
@svenvoskamp
border radius fix + scroll lock adjustment
9899e2a
@vercel
Copy link

vercel bot commented Sep 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
web3modal-gallery ✅ Ready (Inspect) Visit Preview Sep 7, 2023 0:24am
web3modal-laboratory ✅ Ready (Inspect) Visit Preview Sep 7, 2023 0:24am
web3modal-react-wagmi-ex ✅ Ready (Inspect) Visit Preview Sep 7, 2023 0:24am
web3modal-vue-wagmi-ex ✅ Ready (Inspect) Visit Preview Sep 7, 2023 0:24am

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023 •
edited
Loading

Warnings
⚠️ No version updates in packages/wagmi/src/utils/constants.ts file

Generated by 🚫 dangerJS against 1a8e634

@svenvoskamp svenvoskamp marked this pull request as ready for review September 7, 2023 09:56
xzilja
xzilja reviewed Sep 7, 2023
View reviewed changes
Copy link
Contributor

@xzilja xzilja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good code wise, but can we expose border radius option in laboratory to play around with it and test different cases (check how they work)

@svenvoskamp svenvoskamp requested a review from xzilja September 7, 2023 11:44
@svenvoskamp svenvoskamp merged commit 7c6296d into V3 Sep 7, 2023
6 checks passed
@svenvoskamp svenvoskamp deleted the v-3/beta-tweaks-v3 branch September 7, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xzilja xzilja xzilja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svenvoskamp @xzilja